feat(bitcoin): Add phantom wallet adapter #1267
Conversation
gin-lsl
requested review from
yutingzhao1991,
LCJove,
AmAzing129 and
thinkasany
🦋 Changeset detectedLatest commit: e56d9c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Co-authored-by: thinkasany <[email protected]>
|
看到这个 psbt 想到一个问题，钱包更关心的是如何发起一笔交易，其中的 psbt 数据应该是不感知的。 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 858 859 +1
Lines 14726 14729 +3
Branches 1589 1589
=======================================
+ Hits 14725 14728 +3
Misses 1 1 ☔ View full report in Codecov by Sentry. |
| @@ -10,7 +10,7 @@ export interface BitcoinWallet<Provider = any> { | |||
| getBalance: () => Promise<Balance>; | |||
| connect: () => Promise<void>; | |||
| signMessage: (message: string) => Promise<string>; | |||
| sendTransfer: (params: TransferParams) => Promise<string>; | |||
| sendTransfer?: (params: TransferParams) => Promise<string>; | |||
There was a problem hiding this comment.
根据这里的文档，Phantom 只支持 psbt 转账
https://docs.phantom.app/bitcoin/sending-a-transaction
There was a problem hiding this comment.
感觉这个算是钱包自己的特点，可以不要改这里，而是实现一个空的 sendTransfer 方法，里面抛出一个错误提醒开发者？
|
有冲突了 |
添加 Phantom Wallet 的 比特币钱包适配器。
Phantom 的文档见：https://docs.phantom.app/bitcoin/integrating-phantom
注：
sendTransfer或类似方法，所以修改了BitcoinWallet接口；broadcast选项；uint8array-tools依赖，用于对 Uint8Array 值做转换；💡 Background and solution
🔗 Related issue link