-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run post_remediation - quote group_names #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch
hi @diepes This is a great PR and good catch, unfortunatley the PR is not GPG signed so i am unable to accept it. GPG signature and sign off are both required. Many thanks uk-bolly |
8271287
to
8278456
Compare
hi @uk-bolly I added the signature. Cheers, |
Signed-off-by: Pieter Smit <[email protected]>
hi @uk-bolly , |
Overall Review of Changes:
Where run_audit.sh is called from ansible quote the group_name, as it can be a list containing a space.
To resolve a error
Issue Fixes:
Please list (using linking) any open issues this PR addresses
N/A
Resolves issue where there is more than one group, and the -g options fails due to space in command.
/opt/UBUNTU20-CIS-Audit/run_audit.sh ... -g ['all_dev', 'webservers_dev']
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?: