1.4.3 uses wrong var for hash #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan D <[email protected]>
|
hi @dderemiah Thank you as always for raising this PR, i have amended this slightly as this always assumes that it is the root user. So this is more aligned with ubuntu and set slightly differently with more warning around the change. Many thanks uk-bolly |
uk-bolly
added a commit
that referenced
this pull request
Oct 23, 2023
Signed-off-by: Mark Bolwell <[email protected]>
|
Since the PR change is in Oct23 changes branch, can I safely close this PR? |
|
Its all good wil close for you thank you again. uk-bolly |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
found a typo using wrong var for p/w hash
Issue Fixes:
root p/w gets clobbered no more
Enhancements:
n/a
How has this been tested?:
tested locally