Small changes, improved consistency #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pruteanu <[email protected]>
raabf
force-pushed
the
siemens/feat/fix_inconsistencies
branch
from
cdaeb9f
to
f3a9100
Compare
|
Thank you for raising the PRs again, it appears you havent pulled the latest in and the pipelines are now failing. I have just tested and this is workinmg on the latest devel. So your local copy maybe out of sync. If you could close off older PRs you consider no longer required and the associated issues, it will enable to direct attention to those that need attention. Many thanks uk-bolly |
|
Hi @uk-bolly . I made a mistake indeed, but my colleague @raabf helped me out (many thanks!!) with rebasing it, I'd say it should be in good shape, as it branches off out of your Feb updates: The only reference about the undefined-variable causing the pipeline to fail is here, where it is used, but I cannot find where it is defined. Can you help me out with this info, since your devel pipelines work just fine? In my opinion, current PRs are not
|
uk-bolly
added a commit
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Mark Bolwell <[email protected]>
Merged
uk-bolly
added a commit
that referenced
this pull request
Mar 6, 2024
* Issue #170, PR #181 thanks to @ipruteanu-sie * issue #182, PR #183 thansk to @ipruteanu-sie * PR #180 thanks to @ipruteanu-sie and @raabf * Addressed PR #165 thanks to @ipruteanu-sie * PT #184 addressed thansk to @ipruteanu-sie * updated credits * typo and ssh allow_deny comments * enable OS check --------- Signed-off-by: Mark Bolwell <[email protected]>
ipruteanu-sie
pushed a commit
to siemens/RHEL9-CIS
that referenced
this pull request
Mar 11, 2024
* Issue ansible-lockdown#170, PR ansible-lockdown#181 thanks to @ipruteanu-sie * issue ansible-lockdown#182, PR ansible-lockdown#183 thansk to @ipruteanu-sie * PR ansible-lockdown#180 thanks to @ipruteanu-sie and @raabf * Addressed PR ansible-lockdown#165 thanks to @ipruteanu-sie * PT ansible-lockdown#184 addressed thansk to @ipruteanu-sie * updated credits * typo and ssh allow_deny comments * enable OS check --------- Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Pruteanu <[email protected]>
|
This is part of |
uk-bolly
added a commit
that referenced
this pull request
Apr 15, 2024
* Issue #170, PR #181 thanks to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * issue #182, PR #183 thansk to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * PR #180 thanks to @ipruteanu-sie and @raabf Signed-off-by: Mark Bolwell <[email protected]> * Addressed PR #165 thanks to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * PT #184 addressed thansk to @ipruteanu-sie Signed-off-by: Mark Bolwell <[email protected]> * updated credits Signed-off-by: Mark Bolwell <[email protected]> * typo and ssh allow_deny comments Signed-off-by: Mark Bolwell <[email protected]> * enable OS check Signed-off-by: Mark Bolwell <[email protected]> * PR - #198 addressed thanks to @brakkio86 Signed-off-by: Mark Bolwell <[email protected]> * Addressed issue #190 Signed-off-by: Mark Bolwell <[email protected]> * Additional vars for issue #190 Signed-off-by: Mark Bolwell <[email protected]> * updated pre-commit version Signed-off-by: Mark Bolwell <[email protected]> * consistent quotes around mode Signed-off-by: Mark Bolwell <[email protected]> * moved audit added discoveries Signed-off-by: Mark Bolwell <[email protected]> * removed unneeded vars Signed-off-by: Mark Bolwell <[email protected]> * audit moved to prelim Signed-off-by: Mark Bolwell <[email protected]> * tidy up Signed-off-by: Mark Bolwell <[email protected]> * improved new variable usage Signed-off-by: Mark Bolwell <[email protected]> * fixed logic 6.2.10 Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * addressed #197 thanks to @mark-tomich Signed-off-by: Mark Bolwell <[email protected]> * updates for audit section Signed-off-by: Mark Bolwell <[email protected]> * fixed naming Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * added prelim to includes Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Additions done to improve variables/tasks consistency.
Issue Fixes:
N/A
Enhancements:
Consistency improvement.
How has this been tested?:
N/A