Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_net: handle ipv6_cidr: false and no Ipv6CidrBlockAssociationSet in vpc #2374

Merged
merged 6 commits into from
Nov 6, 2024
Merged

ec2_vpc_net: handle ipv6_cidr: false and no Ipv6CidrBlockAssociationSet in vpc #2374

merged 6 commits into from
Nov 6, 2024

Conversation

GomathiselviS
Copy link
Collaborator

SUMMARY

Fixes: #2363

This PR handles the case in which the vpc does not have ipv6 set and the task to modify it has ipv6_cidr: false

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6cb892a50f0d4f729b5726074e063d87

✔️ ansible-galaxy-importer SUCCESS in 5m 20s
✔️ build-ansible-collection SUCCESS in 10m 08s
✔️ ansible-test-splitter SUCCESS in 3m 52s
✔️ integration-amazon.aws-1 SUCCESS in 7m 31s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/199eed7ccf394ceea6d74a7735d05ca4

✔️ ansible-galaxy-importer SUCCESS in 5m 26s
✔️ build-ansible-collection SUCCESS in 10m 18s
✔️ ansible-test-splitter SUCCESS in 4m 38s
✔️ integration-amazon.aws-1 SUCCESS in 8m 18s
Skipped 43 jobs

abikouo
abikouo reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

tests/integration/targets/ec2_vpc_net/tasks/main.yml Outdated
ipv6_cidr: false
register: result

- name: assert the task passes and there is no change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: assert the task passes and there is no change
- name: Assert the task passes and there is no change

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5964491d4fb242f2a60d9b648bdca102

✔️ ansible-galaxy-importer SUCCESS in 5m 55s
✔️ build-ansible-collection SUCCESS in 10m 09s
✔️ ansible-test-splitter SUCCESS in 4m 18s
✔️ integration-amazon.aws-1 SUCCESS in 8m 18s
Skipped 43 jobs

@GomathiselviS GomathiselviS added the mergeit Merge the PR (SoftwareFactory) label Nov 6, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/75e45c41b2d6459cab475bd0bfce98d4

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 11m 04s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-amazon.aws-1 SUCCESS in 7m 40s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Required status check "ansible/gate" is expected.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/bf78378129ee40cb8abfde810336175d

✔️ ansible-galaxy-importer SUCCESS in 4m 45s
✔️ build-ansible-collection SUCCESS in 10m 08s
✔️ ansible-test-splitter SUCCESS in 3m 51s
✔️ integration-amazon.aws-1 SUCCESS in 8m 44s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e5c7e239e0354d3499893534bbd9e191

✔️ ansible-galaxy-importer SUCCESS in 4m 54s
✔️ build-ansible-collection SUCCESS in 10m 04s
✔️ ansible-test-splitter SUCCESS in 3m 56s
✔️ integration-amazon.aws-1 SUCCESS in 9m 44s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f4ff421 into ansible-collections:main Nov 6, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@hakbailey hakbailey hakbailey approved these changes

@abikouo abikouo Awaiting requested review from abikouo

@mandar242 mandar242 Awaiting requested review from mandar242

@gravesm gravesm Awaiting requested review from gravesm

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VPC creation "Failed to wait for IPv6 CIDR association"
4 participants
@GomathiselviS @hakbailey @alinabuzachis @abikouo