Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a single CometBFT dummy validator (backport #4116) #4118

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 29, 2024

Describe your changes

Closes #4096

Only writes a dummy validator to CometBFT's genesis if the number of validators present is lower than 2.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4116 done by [Mergify](https://mergify.com).

Only writes a dummy validator to CometBFT's genesis if the number of
validators present is lower than 2.

(cherry picked from commit 08bd112)
(cherry picked from commit 1021625)
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 29, 2024
@mergify mergify bot merged commit 71fd328 into maint-0.46 Nov 29, 2024
14 of 15 checks passed
@mergify mergify bot deleted the mergify/bp/maint-0.46/pr-4116 branch November 29, 2024 16:26
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (65e1f67) to head (8931c89).
Report is 3 commits behind head on maint-0.46.

Files with missing lines Patch % Lines
crates/node/src/tendermint_node.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           maint-0.46    #4118   +/-   ##
===========================================
  Coverage       74.58%   74.59%           
===========================================
  Files             341      341           
  Lines          107488   107492    +4     
===========================================
+ Hits            80170    80179    +9     
+ Misses          27318    27313    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants