Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (b8dabb2) and [#4019 + #4036] together #4067

Closed
wants to merge 15 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2024

🎉 This combination of pull requests has been checked successfully and will be merged soon. 🎉

Branch main (b8dabb2) and [#4019 + #4036] are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of [#4019 + #4036].
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue duplicated main-queue from automatic merge to main or backport branch for merge:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-success = check-benchmarks
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-success = test-wasm
    • check-neutral = test-wasm
    • check-skipped = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (0)
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (1)
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (2)
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (3)
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (4)
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-integration
    • check-neutral = test-integration
    • check-skipped = test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success = test-unit
    • check-neutral = test-unit
    • check-skipped = test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 4019
  - number: 4036
...

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 77.50000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 74.55%. Comparing base (b8dabb2) to head (0879ed0).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
crates/proof_of_stake/src/types/mod.rs 68.57% 11 Missing ⚠️
crates/proof_of_stake/src/vp.rs 76.92% 3 Missing ⚠️
crates/apps_lib/src/config/genesis/transactions.rs 50.00% 2 Missing ⚠️
crates/proof_of_stake/src/error.rs 0.00% 1 Missing ⚠️
crates/proof_of_stake/src/storage.rs 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4067      +/-   ##
==========================================
+ Coverage   74.32%   74.55%   +0.22%     
==========================================
  Files         341      341              
  Lines      107401   107399       -2     
==========================================
+ Hits        79828    80071     +243     
+ Misses      27573    27328     -245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mergify mergify bot closed this Nov 21, 2024
@mergify mergify bot deleted the mergify/merge-queue/010ca474ee branch November 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants