Set std_in to NoStream on the Anoma client process #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not read from the Anoma client process so we do not need to open a handle to stdin. This fixes an issue where the Anoma client stdin does not get cleaned up correctly on exit which causes subsequent input to the terminal to be corrupted.
paulcadman
force-pushed
the
fix-anoma-client-terminal-corruption
branch
from
15e4f75
to
348f4ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
std_intoNoStreamon the Anoma client process.https://hackage.haskell.org/package/process-1.6.25.0/docs/System-Process.html#t:StdStream
We do not read from the Anoma client process stdin so we do not need to open a handle to stdin.
This fixes an issue where the Anoma client stdin does not get cleaned up correctly on exit which causes subsequent input to the terminal to be corrupted.