-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pattern-matching in variable definitions #3181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
let-patterns
branch
2 times, most recently
from
November 22, 2024 13:03
6e5f02f
to
020e876
Compare
lukaszcz
requested review from
janmasrovira and
paulcadman
and removed request for
janmasrovira
November 22, 2024 13:11
reviewing... |
paulcadman
force-pushed
the
let-patterns
branch
from
November 22, 2024 16:03
b6d9607
to
5e4c18f
Compare
refactors _signName so that the type is more explicit
src/Juvix/Compiler/Concrete/Translation/FromParsed/Analysis/Scoping.hs
Outdated
Show resolved
Hide resolved
janmasrovira
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n@...
. A standalone symbolx
in a definitionx := ...
is always interpreted as an identifier even if there exists a constructorx
.