Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v0.4.3 🎉 #2311

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Bump version to v0.4.3 🎉 #2311

merged 2 commits into from
Aug 24, 2023

Conversation

jonaprieto
Copy link
Collaborator

This PR updates:

  • Package version
  • Smoke test
  • Changelog

@jonaprieto jonaprieto added this to the 0.4.3 milestone Aug 24, 2023
@jonaprieto jonaprieto self-assigned this Aug 24, 2023
@jonaprieto jonaprieto changed the title Bump version to v0.4.3 Bump version to v0.4.3 🎉 Aug 24, 2023
janmasrovira
janmasrovira previously approved these changes Aug 24, 2023
@paulcadman
Copy link
Collaborator

Q: This release contains #2305 - I thought we were reserving this for 0.5.0?

@jonaprieto
Copy link
Collaborator Author

Q: This release contains #2305 - I thought we were reserving this for 0.5.0?

I had the same thought, but it turns out that @janmasrovira merged it 4 hours ago. So, it seems logical to me to label all the merged commits after 0.4.2 as part of tag 0.4.3, including this one.

For now, let's leave it as it is. Next time, we double-check before merging on the day of release to avoid this kind of issue.

@janmasrovira
Copy link
Collaborator

I had the same thought, but it turns out that @janmasrovira merged it 4 hours ago. So, it seems logical to me to label all the merged commits after 0.4.2 as part of tag 0.4.3, including this one.

Well, it is not set in stone, we can always easily use git so that #2305 is not part of 0.4.3

jonaprieto and others added 2 commits August 24, 2023 16:24
* Enables new function syntax in local let-declarations
* Closes #2251
@jonaprieto jonaprieto merged commit bfe6c3e into main Aug 24, 2023
4 checks passed
@jonaprieto jonaprieto deleted the bump-version-to-0.4.3 branch August 24, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants