Add function parscore for compatibility with Deal #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added one more commit that fixes the auction returned by parscore |
|
Thanks for the PR. I ended up rewriting most of the implementation and pushing it directly to main (dropping the functionality of generating a fake auction), but kept you as author on the relevant commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now I have added 500 testcases generated using the TCL code itself to make sure that our function's behavior matches with that of the original TCL implementation. You may want to consider just testing with a random subset of these deals instead by modifying examples/parscore.py
You may also want to consider adding any examples of this in the documentation