feature: Basic GraphQL support #328
Conversation
pavelperc
changed the title
|
hey @pavelperc will check the changes & get back, also, can you check if the GraphQL support can be added as capability to Ktor interceptor as well. |
Hello. In the current implementation no extra integration is needed, because graphql is detected by request body.
All business logic is located in network-core module, so it should work with ktor too. |
| @@ -11,6 +11,7 @@ class NetworkData { | |||
| ) | |||
|
|
|||
| data class Response( | |||
| val request: Request, | |||
There was a problem hiding this comment.
this is an anti-pattern,
Request & Response are mutually exclusive objects.
can understand what you are trying to do here, but lets figure out a better way, than corrupting the Response class.
There was a problem hiding this comment.
Actually, in both ktor and okhttp lib you can access request from response instances, so I thought this is okay.
I will just delete all the logic about parsing response.
There was a problem hiding this comment.
yes thats right,
we have ApiCallData for that purpose only.
| internal val isGzipped: Boolean | ||
| get() = headers["Content-Encoding"].equals("gzip", ignoreCase = true) | ||
| } | ||
|
|
||
| data class Response( | ||
| val request: Request, |
| ) { | ||
| private val contentTypeInternal: ContentType = ContentType.parse(contentType) | ||
| private val mediaType: String = contentTypeInternal.contentType | ||
| internal val mediaSubtype: String = contentTypeInternal.contentSubtype | ||
| internal val isBinary: Boolean = BINARY_MEDIA_TYPES.contains(mediaType) | ||
| val sizeInBytes: Long = body.length.toLong() | ||
| internal val mediaTypeFull: String = "$mediaType/$mediaSubtype" | ||
| val isLikelyJson get() = !isBinary && body.startsWith('{') |
There was a problem hiding this comment.
cant this be decided based on mediaType or mediaSubtype?
fixes #326
Hello. I added a basic GraphQL support for network plugin. It recognises POST api calls with "query" part in it and shows query name and type instead of api path in api calls list.
Also, it recognises errors in api response and paints api calls in red, even if the status code is 200.You may not like the way it is done. I thought about making a separate graphql interceptor with apollo graphql library (https://www.apollographql.com/docs/kotlin/advanced/interceptors-http), but graphql calls use http under the hood, so grapqhl calls would be duplicated in http interceptor. Also different clients use different versions of apollo library (2x, 3x, 4x), and it is a bad way to add a dependency only with one version of library. I thought it would be easier to parse raw request, rather then add an interceptor, but we can discuss and I can redo the implementation.
UPD. Image 2 (error handling) is not supported, see discussion