add support for cperl and fixed YAML::XS #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurban
added a commit
to perl11/cperl
that referenced
this pull request
Feb 17, 2017
rurban
force-pushed
the
cperl
branch
2 times, most recently
from
96d966f
to
5bee679
Compare
rurban
added a commit
to perl11/cperl
that referenced
this pull request
Aug 27, 2018
Updated andk/cpanpm#109
rurban
added a commit
to perl11/cperl
that referenced
this pull request
Sep 12, 2018
From 5.28.0c See L<andk/cpanpm#109>
rurban
force-pushed
the
cperl
branch
2 times, most recently
from
7242b0e
to
9459b3a
Compare
allow cperl c suffices honor cperl builtin modules
Use the builtin YAML::XS in NonStrict mode.
The previous default YAML is actually the worst choice at all.
* It's not builtin (compared to CPAN::Meta::YAML),
* it's the slowest (and performance matters with CPAN),
* it does not understand YAML::XS yaml,
* it errors on the simpliest YAML violations, where others continue.
YAML::Syck would be a better choice as it does not implement the unsafe
YAML 1.1 spec, but cperl put an improved YAML::XS into core.
Try Safe{Load,Dump}File before trying {Load,Dump}File.
cperl is working on that feature.
for all CPAN modules, scripts and subprocesses.
on cperl, and error on CPAN::Meta::YAML. Work to support CPAN::Meta::YAML features is ongoing See [cperl andk#155]
ignore inc with Test::More because it clashes with the modernized Test::More variant in cperl. add YAML::XS to t/31sessions.t to be ignored.
Perl::Critic found these violations in "lib/CPAN/FirstTime.pm": lib/CPAN/FirstTime.pm: Subroutine "init" with high complexity score (154) at line 774, column 1. Consider refactoring. (Severity: 3)
with symlinks crossing mountpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using these fixes for the last 2 years in cperl.
Tested for all major perl versions.
Note: The YAML::XS situation is still unclear, as upstream maintainers were doing nothing
for the last years. (I heard is rather working on a 3.0 than fixing 2.x)
So far only the version is cperl is usable.
I added API support for future SafeLoadFile, which I'll probably have to implement in a fork.
A fast YAML in core is critical for cpan performance. It's 10x faster.
Needs
make touchtestdistros