Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed undefined props on main View style props #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grnsmn
Copy link

@grnsmn grnsmn commented Mar 22, 2023

Hi there,

I've made a small bugfix to the main render component of the library. Specifically, I removed an undefined property that was being passed in the style prop of the view. This should resolve the issue and improve the overall functionality of the component.

Thanks for considering my contribution! Let me know if you have any questions or concerns.

Best regards,
Simone

…ent to fix when extend style view from outside
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this

Copy link

@lennertderyck lennertderyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem correct.

After encountering the same problem, patching the problem this way fixed the error.

@timborovkov
Copy link

Can someone please merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants