Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up retry count config to NVD provider #738

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

wagoodman
Copy link
Contributor

This PR primarily wires up a new request_retry_count option to NVD with a default of 10 (a rather high number since the API tends to show issues). This also adjusts the jitter and display behavior of the http.get helper:

  • now the sleep interval (and not the backoff) is shown when in the "attempting in X seconds" log message
  • jitter applies to the first sleep interval (not the second)

@wagoodman wagoodman added the enhancement New feature or request label Nov 26, 2024
@wagoodman wagoodman enabled auto-merge (squash) November 26, 2024 16:04
@wagoodman wagoodman added the run-pr-quality-gate Triggers running of quality gate on PRs label Nov 26, 2024
@wagoodman wagoodman requested a review from a team November 26, 2024 16:13
@wagoodman wagoodman self-assigned this Nov 26, 2024
Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman merged commit d426c26 into main Nov 26, 2024
11 of 13 checks passed
@wagoodman wagoodman deleted the wire-up-nvd-retry branch November 26, 2024 19:20
@wagoodman
Copy link
Contributor Author

Bypassed checks since NVD API is in a degraded state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request run-pr-quality-gate Triggers running of quality gate on PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants