Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver support for MAX42500 #2659

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kentlibe
Copy link

@kentlibe kentlibe commented Dec 1, 2024

PR Description

  • This adds driver support for the MAX42500 Industrial Power System Monitor Family, along with corresponding device tree bindings.
  • Datasheet MAX42500
  • Tested in RPI4 with MAX42500_EVKIT_P1.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

@nunojsa
Copy link
Collaborator

nunojsa commented Dec 2, 2024

Is this still WIP? As it stands it's not really ready for reviewing... Please make sure to address CI complains and to re-organize your commits. Merge commits don't really make sense (rebase your dev branch) and please run git lon --oneline <DIR_YOU'RE_CHANGING> so you can the git log style for that subsystem. Then, please follow the same style. Also note that a commit as Cleanup MAX42500 Linux driver. is not fine. You need to explain what you're actually cleaning and why...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants