Small improvements on jesd204 and users #2648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunojsa
requested review from
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
nunojsa
force-pushed
the
staging/small-improvs
branch
from
553cdee
to
523233a
Compare
|
v2:
|
There's no need to allocate a new devres context. Just use devm_add_action_or_reset(). Signed-off-by: Nuno Sa <[email protected]>
Add a device managed version of jesd204_fsm_start(). Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it and as it seems the framework is optional, only start it if jdev is not NULL. This is not a check that should be handled in the core and I plan to change that in the future. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it and as it seems the framework is optional, only start it if jdev is not NULL. This is not a check that should be handled in the core and I plan to change that in the future. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it and as it seems the framework is optional, only start it if jdev is not NULL. This is not a check that should be handled in the core and I plan to change that in the future. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it and as it seems the framework is optional, only start it if jdev is not NULL. This is not a check that should be handled in the core and I plan to change that in the future. Also simplify probe with devm_platform_ioremap_resource(). Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it and as it seems the framework is optional, only start it if jdev is not NULL. This is not a check that should be handled in the core and I plan to change that in the future. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it and as it seems the framework is optional, only start it if jdev is not NULL. This is not a check that should be handled in the core and I plan to change that in the future. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it and as it seems the framework is optional, only start it if jdev is not NULL. This is not a check that should be handled in the core and I plan to change that in the future. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it and as it seems the framework is optional, only start it if jdev is not NULL. This is not a check that should be handled in the core and I plan to change that in the future. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it, remove the .remove() hook by using devm APIs or devm_add_action_or_reset(). Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. While at it, remove the .remove() hook by using devm APIs or devm_add_action_or_reset(). Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. Signed-off-by: Nuno Sa <[email protected]>
We should stop the jesd204 FSM on unbind. Signed-off-by: Nuno Sa <[email protected]>
nunojsa
force-pushed
the
staging/small-improvs
branch
from
523233a
to
7e8d930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR improves devm_jesd204_dev_register() and adds a new devm_jesd204_fsm_start() API so we make sure to stop the FSM on unbind. Then, we update all users jesd204_fsm_start() () to use the new variant. ALong the way some drivers were completely converted to a full devm probe (meaning that we do not need any driver .remove() hook)
PR Type
PR Checklist