plugins/dac_data_manager: Create iio buffer at the right moment #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents osc from crashing at startup. The idea behind the fix is the following: due to libiio v1.x API changes the creation of the iio_buffer cannot be done too early. It needs a iio_mask and at least one channel to be enabled. The need to create the iio_buffer early was just to read one attribute about alignment, and to read the attribute only once. The fix is to create the iio_buffer at the moment is needed and read the attribute right after the creation. Signed-off-by: Dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The idea behind the fix is the following: due to libiio v1.x API changes the creation of the iio_buffer cannot be done too early. It needs a iio_mask and at least one channel to be enabled. The need to create the iio_buffer early was just to read one attribute about alignment, and to read the attribute only once.
The fix is to create the iio_buffer at the moment is needed and read the attribute right after the creation.
The effort for this fix started because osc was crashing at startup.
PR Type
PR Checklist