dialogs.c: move the scanning process into its own thread. #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraTrifan
requested review from
cristina-suteu,
dNechita and
mhennerich
as code owners
dNechita
reviewed
Apr 19, 2024
nunojsa
reviewed
Apr 19, 2024
On MacOS there were some issues with the network iio_context scanning process. Inside libiio, some mutex locks are done during scanning. This blocks the UI thread and makes the app unusable. Moving into its own thread and creating a protected section (similar to calibration processes) should resolve this issue. Signed-off-by: AlexandraTrifan <[email protected]>
AlexandraTrifan
force-pushed
the
altrifan/test-mac-scan
branch
from
4a87da4
to
971b129
Compare
nunojsa
approved these changes
Apr 19, 2024
dNechita
approved these changes
Apr 22, 2024
cristina-suteu
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
On MacOS there were some issues with the network iio_context scanning process. Inside libiio, some mutex locks are done during scanning. This blocks the UI thread and makes the app unusable. Moving into its own thread and creating a protected section (similar to calibration processes) should resolve this issue.
Besides these changes, iio-osc also needs some different fixes to get it working on MacOS (here are 2 dev branches on this matter by Cristina and Travis).
PR Type
PR Checklist