Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix CNTRL_2 DATA_FORMAT field #1421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spectrum70
Copy link

Noted that in my application, ad3552r-axi, i need to set this bit (4) to 0 to have unsigned 16bit samples generated.

PR Description

Fix DAC IP documentation.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Noted that in my application, ad3552r-axi, i need to set this bit
(4) to 0 to have unsigned 16bit samples generated.

Signed-off-by: Angelo Dureghello <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sarpadi sarpadi requested a review from caosjr October 1, 2024 11:18
@PopPaul2021 PopPaul2021 self-requested a review October 1, 2024 11:18
@sarpadi
Copy link
Contributor

sarpadi commented Oct 1, 2024

Tagging @caosjr

Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @spectrum70,

The AD3552R requires the data to be in offset binary format on the QSPI interface. We can verify this by replacing the binary code with 0 or 2^16-1 in the Transfer function formula (datasheet page 27). Therefore, we need to set the bit to one to convert the data from the DMA or the ADC from 2’s complement to offset binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants