-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hand detect data stream #813
Open
DanielMatyas
wants to merge
3
commits into
main
Choose a base branch
from
hand-detect-data-stream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMatyas
force-pushed
the
hand-detect-data-stream
branch
2 times, most recently
from
September 28, 2023 11:14
9a4093d
to
36bae68
Compare
Removed Snap! button and Process tab from the notebook. Changed image display from label to a separate window, in order to have better frame rate. The camera requests only the depth image. After clicking on Start Video, the depth image is displayed continuously. Every 1 second a process of finger detection is started on a different core. After finishing the calculation the bounding box of the hand and the number of detected fingers is updated. Signed-off-by: Daniel Matyas <[email protected]>
First of all, it is faster, because there is no GUI, only computation. Used depth image directly for computation; did not convert image to RGB. Made max distance of the bit image dynamic. It depends on the closest pixel. Changed hand center to the point farthest from the background Made cdist_threshold dynamic. It is inversely proportional to the max distance of bit image. Selected the vertex which is farthest from the hand center on every finger. Neglected the vertices which are below the wrist. Signed-off-by: Daniel Matyas <[email protected]>
DanielMatyas
force-pushed
the
hand-detect-data-stream
branch
from
September 28, 2023 11:17
36bae68
to
6b7ccdf
Compare
Hi @DanielMatyas! Just checking if this is this ready to be reviewed. Is it? |
DanielMatyas
force-pushed
the
hand-detect-data-stream
branch
from
October 25, 2023 11:20
6b7ccdf
to
8b2b83e
Compare
Yes. It is ready for review @dNechita . |
Added more commentaries and made code look somewhat nicer. Signed-off-by: Daniel Matyas <[email protected]>
DanielMatyas
force-pushed
the
hand-detect-data-stream
branch
from
November 13, 2023 08:49
8b2b83e
to
a008da5
Compare
dNechita
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect number of fingers extended on data stream.