Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ampli react native error with set instance #327

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix: ampli react native error with set instance #327

merged 3 commits into from
Sep 23, 2024

Conversation

justin-fiedler
Copy link
Contributor

@justin-fiedler justin-fiedler commented Jul 11, 2024 •
edited by jira bot
Loading

AMP-104265

Summary

  • Update ReactNative sample to use 1.1.7 of@amplitude/analytics-react-native
  • Update to Gradle 7.3

@justin-fiedler justin-fiedler requested review from crleona, izaaz and a team July 11, 2024 18:39
crleona
crleona approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@crleona crleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mercy811
Copy link
Contributor

Even though checks failed, still merge this PR because the PR is not the cause.

"Ampli Merge Check (ReactNative V2)" -> "Check the Data branch is merged before merging the Git branch" failed

2m 4s
Run ampli status --is-merged -t ***
✘ ERROR network timeout at: https://data-api.staging.amplitude.com/graphql

"CI - React Native V2 Tests / build (14.x)" -> "JS - Install" failed

Run yarn install --frozen-lockfile
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
error Error: connect ECONNREFUSED [12](https://github.com/amplitude/ampli-examples/actions/runs/11000237397/job/30542908084?pr=327#step:6:13)7.0.0.1:4873
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1159:16)
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@Mercy811 Mercy811 merged commit 94e48d0 into main Sep 23, 2024
0 of 2 checks passed
@Mercy811 Mercy811 deleted the AMP-104265-ampli-react-native-error-with-set-instance branch September 23, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaaz izaaz izaaz approved these changes

@crleona crleona crleona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justin-fiedler @Mercy811 @crleona @izaaz