Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCustomAdvertisingId #102

Closed
wants to merge 1 commit into from
Closed

Conversation

vishna
Copy link
Contributor

@vishna vishna commented Apr 19, 2022

solves #101

@@ -304,6 +304,15 @@ class Amplitude extends _Amplitude {
'setMinTimeBetweenSessionsMillis', jsonEncode(properties));
}

/// Android only, allows to provide a custom advertising id
Future<void> setCustomAdvertisingId(String advertisingId) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if need some placeholder method in iOS and web @yuhao900914

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. Both ios and web need a placeholder otherwise it's not able to build. @vishna Can you please update this?

Copy link
Contributor

@yuhao900914 yuhao900914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a function mapping placeholder in both ios and android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants