Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrofit a new version of cpplint. Ignore Qt generated moc_ files. #501

Closed
wants to merge 4 commits into from
Closed

Retrofit a new version of cpplint. Ignore Qt generated moc_ files. #501

wants to merge 4 commits into from

Conversation

rodericktaylor
Copy link
Contributor

Addresses. #500

@fujitatomoya
Copy link

@rodericktaylor thanks for the PR.

Can we divide this PR into 2 parts?

  • Ignore checking moc generated cpp file by ament_clang_tidy package.
  • Retrofit a new version of cpplint in ament_cpplist package. (against original issue ament_cpplint Support for C++20 #500) especially this one, we need to see what happens to all downstream packages with new version by running CI before merging it.

@clalancette clalancette added the more-information-needed Further information is required label Oct 17, 2024
@rodericktaylor
Copy link
Contributor Author

Yep. Will do. I'll close this PR and create another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
more-information-needed Further information is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodericktaylor @fujitatomoya @clalancette