Pinned golang and node to older versions in Dockerfile #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing release histories, I picked golang 1.18 and node 14 as likely candidates for the old build. I also moved to a multistage build so that the only thing left was the compiled binary.
AndrewO
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing release histories, I picked golang 1.18 and node 14 as likely candidates for the old build. I also moved to a multistage build so that the only thing left was the compiled binary.
I was running into the same issue as in #78 so I pinned Node to 14 (which, I believe was LTS when this was last released). Then I made it a multi-stage build container so that none of those older versions would be around in the final artifact.