Pin versions of alpine and node-modules #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More recent versions of golang:alpine fail to compile due to go get being deprecated in favour of go install, so this pins the golang container to 1.15, when go get was still supported. Also, it copies over the package-lock.json file from the webapp folder so that the npm modules also get their versions pinned to ones that still work; otherwise there were some dependency tree issues while trying to install node modules that would cause the docker build to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More recent versions of
golang:alpinefail to compile due togo getbeing deprecated in favour ofgo install, so this pins the golang container to 1.15, whengo getwas still supported. Also, it copies over the package-lock.json file from the webapp folder as part of the docker build so that the npm modules also get their versions pinned to ones that still work; otherwise there were some dependency tree issues while trying to install node modules that would cause the docker build to fail.I tried going up to
golang:1.16-alpine, butnpm buildin 1.16 was arguing with me and I didn't have time to explore it further, so left the image pinned togolang:1.15-alpine, which seems to work out of the box.