Fix dependencies and add go.mod #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It was not possible to use the package with Go modules because the dependency "github.com/willf/bitset" moved to "github.com/bits-and-blooms/bitset". - The dependencies were updated to the latest stable version. - The package was modernized to use Go modules.
The msb function was updated to use the `bits` package.
- Fix the example outputs, since obj.Next() is called before printing the first value in the array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to use the package with Go modules because the dependency 'github.com/willf/bitset' doesn't exist anymore (it was moved to 'github.com/bits-and-blooms/bitset').
The dependencies were updated to the latest stable version.
The package was modernized to use Go modules.
The msb function was updated to use the
bitspackage, which is faster than using math.Log2.Fix the example outputs, since obj.Next() is called before printing the first value in the array.