-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add simple e2e tests using Cypress #3025
base: dev
Are you sure you want to change the base?
Conversation
I will add NPM e2e test script (should start http-server to serve the current folder, run Cypress), and for this open source project we can even setup free dashboard to store videos and screenshots on failures https://www.cypress.io/dashboard/ |
I add test scripts ( |
@alvarotrigo any thoughts on adding e2e tests using Cypress? |
Hi @bahmutov! Thanks for the pull request! Although I won't consider merging it as it is now. I would really like to see the power of the tool, something perhaps more complex than texting scrolling to certain sections or slides? Why should I go for cypress instead of QUnit? Few things if you plan to create another PR:
|
Sure @alvarotrigo you control what gets changed. I was just trying to describe everything, but it can be done step by step.
As far as overall power - you can see what Cypress is doing during the test, which is kind of hard to do using QUnit. It also intelligently waits for assertions, so the tests do not need |
I'm not currently interested in testing the examples. They barely get changed. My priority at the moment would be to test all the features provided by the library to make sure I do not break anything after any change (and perhaps even test private methods, as I want to make sure they don't break at any point, possible using this method?) |
1- Make sure to commit it to the
dev
branch!2- Read https://github.com/alvarotrigo/fullPage.js/wiki/Contributing-to-fullpage.js
This branch adds end to end tests with a GUI using cypress.io test runner.
Example test
Example GUI during testing
Test run recording (built-in) at https://youtu.be/Yzodhs8MayA
For more info about this E2E test runner