Fix: Fix issues around incorrect tags not being sent to Grafana + Add ruff format to repo #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2024
|
Thanks @jmfiola for this and the addition of ruff format. LGTM to me to merge. But will have to wait for @alteryx-sezell since she is the only code owner currently. |
devashish2203
changed the title
devashish2203
approved these changes
Jun 18, 2024
|
Updated and merged #43 to add more code owners. But would still wait for another set of eyes on the changes before merging. |
skezell
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tag propogation issues we were seeing in issue 40, and also introduces
ruff format --check .into the quality checks pipeline, which is the request from issue 41.