Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataChecks migration from EvalML into CheckMates #15

Merged
merged 4 commits into from
Aug 15, 2023
Merged

DataChecks migration from EvalML into CheckMates #15

merged 4 commits into from
Aug 15, 2023

Conversation

NabilFayak
Copy link
Collaborator

@NabilFayak NabilFayak commented Aug 14, 2023 •
edited
Loading

  • all datachecks except for invalid_target have been migrated over from EvalML along with testing and relevant utils

resolves #14

ParthivNaresh
ParthivNaresh reviewed Aug 15, 2023
View reviewed changes
Copy link

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Are we leaving InvalidTargetDataCheck out because of the EvalML objectives dependency? Do we have a plan for integrating that?

tests/data_checks_tests/test_target_distribution_data_check.py Outdated Show resolved Hide resolved
@NabilFayak
Copy link
Collaborator Author

Looks good overall! Are we leaving InvalidTargetDataCheck out because of the EvalML objectives dependency? Do we have a plan for integrating that?

yeah we have a plan for integrating that, it's just causing a lot of errors and is a very big merge, so I figured splitting it up from this request might be a good idea

@NabilFayak NabilFayak merged commit 6e2bc39 into main Aug 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParthivNaresh ParthivNaresh ParthivNaresh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datachecks migration
2 participants
@NabilFayak @ParthivNaresh