Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Buf files #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added Buf files #173

wants to merge 1 commit into from

Conversation

Jonathan-Landeed
Copy link

Adding these files allows the project to be uploaded to the buf.build BSR. Apparently it won't work as a remote plugin, but it's still nice as a dependency for import "patch/go.proto"; in Buf projects.

See bufbuild/plugins#858

@ydnar
Copy link
Contributor

ydnar commented Oct 5, 2024

Thanks! Is this a registry of Buf plugins? Should I create a username there to register this?

ydnar added a commit that referenced this pull request Oct 5, 2024
@ydnar ydnar mentioned this pull request Oct 5, 2024
@ydnar
Copy link
Contributor

ydnar commented Oct 5, 2024

I created #174 which replicates this PR using an official distribution at https://buf.build/alta/protopatch.

Do you have a sense for what should be in the README to document how Buf users would use this?

  - local: protoc-gen-go-patch
    out: gen
    opt:
      - paths=source_relative
      - plugin=go

@ydnar
Copy link
Contributor

ydnar commented Oct 5, 2024

If you want to grab the changes from #174 and incorporate them here, I'd also like to see tests (local, CI) that validate Buf works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants