-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new teal opcodes for the MiMC hash function to support Zero Knowledge Proofs #5978
Open
giuliop
wants to merge
13
commits into
algorand:master
Choose a base branch
from
giuliop:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+255
−22
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aa86260 - Browse repository at this point
Copy the full SHA aa86260View commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f17fd30 - Browse repository at this point
Copy the full SHA f17fd30View commit details -
It's a little ugly to re-use the ec constants, maybe that should be changed. This also changes the opcode to panic on buffers than contain elements greater than the curve's modulus. It's unclear what mimc should do with a zero buffer. Even gnark seems unsure. Their code says: ``` // TODO @ThomasPiellard shouldn't Sum() returns an error if there is no data? // TODO: @Tabaie, @thomas Piellard Now sure what to make of this /*if len(d.data) == 0 { d.data = make([]byte, BlockSize) }*/ ```
Configuration menu - View commit details
-
Copy full SHA for d44a8a7 - Browse repository at this point
Copy the full SHA d44a8a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45b97c0 - Browse repository at this point
Copy the full SHA 45b97c0View commit details
Commits on May 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3979001 - Browse repository at this point
Copy the full SHA 3979001View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad777e3 - Browse repository at this point
Copy the full SHA ad777e3View commit details
Commits on May 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2de29ea - Browse repository at this point
Copy the full SHA 2de29eaView commit details
Commits on Jun 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1472ed6 - Browse repository at this point
Copy the full SHA 1472ed6View commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 247d717 - Browse repository at this point
Copy the full SHA 247d717View commit details
Commits on Oct 8, 2024
-
Make the parameters of the MIMC construction explicit. Better document its intended use case.
Configuration menu - View commit details
-
Copy full SHA for 809067d - Browse repository at this point
Copy the full SHA 809067dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0e84c9 - Browse repository at this point
Copy the full SHA f0e84c9View commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa2e748 - Browse repository at this point
Copy the full SHA fa2e748View commit details
Commits on Nov 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d9c3282 - Browse repository at this point
Copy the full SHA d9c3282View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.