-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom number formatting #135
base: master
Are you sure you want to change the base?
Conversation
Like I said in the PR you linked, I wouldn't do it without |
Rolling your own |
I only suggested we shouldn't improvise |
Btw, my guess you're in need to format monetary values. If that's the case, may I suggest using a library that does just that? accounting.js looks good |
My use case is actually formatting numbers (not monetary) in an Angular application where we are using different locales depending on user settings. And there it's as easy as just using |
Btw, are you using the Re extensibility: I totally understand what you're saying. Though I'm not that happy with the implementation of this lib (made some bad decisions in my youth 😀), it pretty much does what it's supposed to do and so I'm satisfied. Also the npm stats are positive. However, about a month ago I started thinking that it might be the time to move on and surpass |
Yes, I'm using the Idea about a shiny new lib is definitely interesting! But yeah, adding some extensive features to |
Just wondering where this has got to. I also have a need to format large numbers (not currency) and it would be handy to have this in sprintf |
Added support for custom number formatting. This way one can override the default formatting to support localization.
Since localization usually depends on the environment (e.g. using Angular) the actual localization can as well be externalized.
Should help with #124.