Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction of support to TTML #15

Draft
wants to merge 439 commits into
base: develop
Choose a base branch
from
Draft

Introduction of support to TTML #15

wants to merge 439 commits into from
+8,602 −714

Conversation

alexandercerutti
Copy link
Owner

@alexandercerutti alexandercerutti commented Feb 18, 2024 •
edited
Loading

Breaking changes

  • (Re)Introduced Entities.Style;
  • Removed Entities.Tag.setStyles;
  • Removed the concepts of offset and length in lines;
  • (Behavior) Adapters now are in charge of specifing the entities to apply to specific cues, in a ordered way (captions-renderer won't re-order them anymore)

@alexandercerutti
Removed parent chain querying for timeContainer
161e0da
@alexandercerutti
Added relationship span self-reference
ba87e94
@alexandercerutti
Changed default time base provider to be Media
6913309
@alexandercerutti
Added local data processing on mergeWith for StyleContext and RegionC…
e4629ac 
…ontext
@alexandercerutti
Added some testa for StyleContext in scope
7a3da86
@alexandercerutti
Added more comments
ae2dc0b
@alexandercerutti
Removed all references to LogicalGroupingContext
9db873f
@alexandercerutti
Added support to time context proxies
db6da67
@alexandercerutti
Started implementation for parseCue with some unit tests
93fa23f
@alexandercerutti
Made TimeDetails properties all optional
a7e4a45
@alexandercerutti
Added timeBase indentifying symbol for debugging purposes
15f4190
@alexandercerutti
Fixed inverted attributes when creating time context on parseCue
0d0764c
@alexandercerutti
Set Adapter to use parseCue
1d54847
@alexandercerutti
Changed how RelationshipTree and nodes work to fix recursive nodes
229f89c
@alexandercerutti
Added random ids to styles without xml:id
044ef91
@alexandercerutti
Added region matching to parseCue
9400f9c
@alexandercerutti
Removed missed console.log for regions matching
5070176
@alexandercerutti
Set StyleContext to return a Map instead of an array and made stylePa…
e5e152f 
…rser to take out all the attributes that do not start with tts
@alexandercerutti
Added base test for Adapter
a8b28e6
@alexandercerutti
Added playwright test to verify entities content separation when an e…
d5b3cb6 
…ntity is placed in the middle of a word
@alexandercerutti
Set IntervalBinaryTree to add node on its left only if it is lower an…
4857301 
…d not equal to preserve cues order
@alexandercerutti
Set webvtt-adapter to create a new cue on entity opening and closing
cf63d99
@alexandercerutti
Removed cue splitting by entities inside TreeOrchestrator as redundant
b6bacab
@alexandercerutti
Improved if in TreeOrchestrator loop
4b2d8d9
@alexandercerutti
Removed entities tree IntervalBinaryTree separation as the entity sel…
d86025c 
…ection for a cue is already delegated to the renderer, even when a word is split
@alexandercerutti
Improved loop with continue
58c1d3e
@alexandercerutti
Fixed parseCue creation of useless cueNodes by checking if they are e…
1e57775 
…mpty first
@alexandercerutti
Removed offset and length from entities, entity leafability, refactor…
437cd96 
…ed orchestrator and cueNode entities sorting
@alexandercerutti
Changed tests for IntervalBinaryTree
9951ee1
@alexandercerutti
Removed offset and length from entities specs
940da4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexandercerutti alexandercerutti

Labels
💥 Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi line does not preserve style
1 participant
@alexandercerutti