[FIX] PG env use the DB_ vars like intended in the container #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickBrun
force-pushed
the
fix_pg_env
branch
from
7c65814
to
7e14c2e
Compare
PierrickBrun
force-pushed
the
fix_pg_env
branch
from
7e14c2e
to
1cc4541
Compare
|
@hparfr Je viens de reprendre cette PR avec le dernier déploiement |
|
Pour moi c'est ok, j'ai juste un doute, il me semble que définir a la fois PG_DATABASE et ODOO_DB évite les erreurs (les chemins au run et exec ne sont pas les mêmes) |
|
Je ne suis pas sûr qu'on parle de la même chose car ODOO_DB ne me dit rien Mais si tu veux parler de PGDATABASE et DB_DATABASE, en principe il DB_* est exporté dans PG* au lancement du container: Du coup Pour moi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.