Xcode 16: fix warnings for types that inherit @unchecked Sendable
#2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
reviewed
Sep 10, 2024
Comment on lines
+88
to
+91
| /// `CombinedShapeItem` inherits `@unchecked Sendable` from `ShapeItem` and | ||
| /// we need to restate that here to avoid a warning in Xcode 16 | ||
| // swiftlint:disable:next no_unchecked_sendable | ||
| extension CombinedShapeItem: @unchecked Sendable { } |
There was a problem hiding this comment.
Can we use a full Sendable conformance instead of @unchecked Sendable?
These model types are final and only have immutable properties, so they are Sendable without having to use @unchecked.
Suggested change
| /// `CombinedShapeItem` inherits `@unchecked Sendable` from `ShapeItem` and | |
| /// we need to restate that here to avoid a warning in Xcode 16 | |
| // swiftlint:disable:next no_unchecked_sendable | |
| extension CombinedShapeItem: @unchecked Sendable { } | |
| extension CombinedShapeItem: Sendable { } |
There was a problem hiding this comment.
If this works I would suggest putting the Sendable conformance in the main declaration instead of as an extension, like:
final class CombinedShapeItem: ShapeItem, Sendable {There was a problem hiding this comment.
Unfortunately that still doesn't silence the warning
calda
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 26 warnings in Xcode 16 by restating inherited conformances to
@unchecked Sendable. An example:The unchecked conformances were originally added in #2126.