-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated validate_inputs_base
#17
Conversation
@qiaojunfeng this PR is blocked until the commit described above is released, but already wanted to give you a heads up. |
Thanks, Marnik! The commit message aiidateam/aiida-quantumespresso@a389629 is very good and clear^^
Do you have any plan of when to release a new version of aiida-qe? Once that it done I can safely merge this |
Soon, but it's the same old story of "let me just get one more PR in". ^^ In this case it's aiidateam/aiida-quantumespresso#640, but that triggered a small documentation rabbit hole excursion. Still, I'd like to release the new version this week, since also aiidalab-qe is counting on it due to failing tests. EDIT: Do you have an idea when you'll release v2.X support for these work chains? 🙃 |
8247d1e
to
33c0088
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 43.22% 43.20% -0.03%
==========================================
Files 44 44
Lines 4217 4215 -2
==========================================
- Hits 1823 1821 -2
Misses 2394 2394
☔ View full report in Codecov by Sentry. |
33c0088
to
39ab264
Compare
@qiaojunfeng I've updated the |
@qiaojunfeng can I go ahead and merge this? |
Sorry for the delay, just merged it! |
In aiidateam/aiida-quantumespresso@a389629, the validation of the
parent_folder
was adapted to no longer rely on splitting up the validation of the top-level inputs invalidate_inputs
andvalidate_inputs_base
. Instead, a wrapping work chain can just exclude theparent_folder
when exposing the inputs of e.g. aPwBaseWorkChain
whoseparent_folder
will be obtained at run-time.Here we remove the line adapting the validator of the
PwCalculation
in thenscf
namespace of theWannier90WorkChain
tovalidate_inputs_base
, and excludepw.parent_folder
from this namespace instead.