Migrate formatter and linter to ruff #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 93.39% 93.40%
=======================================
Files 28 28
Lines 999 970 -29
=======================================
- Hits 933 906 -27
+ Misses 66 64 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
agoscinski
force-pushed
the
update-ruff-settings
branch
from
28fac86
to
7ab9faf
Compare
|
I added N80* ignores to the ruff file since we move away from python naming convention at several places. This is because we follow in these cases GraphQL naming convention. |
agoscinski
force-pushed
the
update-ruff-settings
branch
4 times, most recently
from
b34af28
to
e48f4b8
Compare
agoscinski
force-pushed
the
update-ruff-settings
branch
2 times, most recently
from
8a421af
to
3b7e343
Compare
We migrate to ruff for the linter and formatter with the settings of aiida-core as well as the pre-commit hooks used for formatting. This makes the repository more compatible with aiida-core and also allows solves more linter problems automatically which should speed up development
In several places we do not follow the pep8 naming convention but rather GraphQL one. We therefore add the N80* linter ignores to disable the linter for these cases.
This commit is mainly the result of running `pre-commit run --all-files` with the previous changes in the formatter and linter. There is some additional manual changes to fix linebreaks.
agoscinski
force-pushed
the
update-ruff-settings
branch
from
3b7e343
to
11d8aad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the goal is to integrate this repo back to aiida-coreTo be more compatible with newest aiida-core version this PR migrates linter to ruff with the settings as they are used in aiida-core