Fix: Set common inputs to non_db
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the updates in version 2.6 of `aiida-core`, the `to_aiida_type` serializer is used as a default. Therefore, the validation fails for the inputs defined in the common interfaces, as those are typically defined as Python datatypes. Since these inputs are anyway not stored in the database, we fix it by explicitly setting `non_db = True` for those inputs.
t-reents
force-pushed
the
fix/compatible_with_aiida_2_6
branch
from
d3892d7
to
7cf7d12
Compare
giovannipizzi
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After setting
to_aiida_typeas the default serializer inaiida-core 2.6, the common workflows would fail. The common inputs expect Pyhton data types instead of their corresponding AiiDA data types. Instead of adding the corresponding AiiDA data types as valid types, I setnon_db = Truefor the common inputs, since the inputs were not stored in the database before, anyway.