-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[atddiff] Offer '--no-locations' option #382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
results with --no-locations.
weird and may not be the best solution for tracking atddiff findings over time.
mjambon
requested review from
rgrinberg,
Khady,
zindel and
cyberhuman
as code owners
October 26, 2023 03:26
mjambon
added a commit
to mjambon/opam-repository
that referenced
this pull request
Oct 27, 2023
CHANGES: * atddiff: Breaking changes in the JSON output format of atddiff (ahrefs/atd#382) * atddiff: Fix `atddiff --version` output (ahrefs/atd#379) * atddiff: New experimental option `--no-locations` aimed at producing more stable results that allow diffing successive atddiff reports to spot new findings and ignore old ones (ahrefs/atd#377)
jchavarri
added a commit
to jchavarri/atd
that referenced
this pull request
Nov 1, 2023
* master: Stop using the extension sphinx_rtd_theme This makes the two grammar tables slightly less pretty but still readable. Trying to build the docs with a version of Python that works on my machine Another attempt to fix the docs Uncomment config section that looks like what we need (ahrefs#389) Add sphinx_rtd_theme to requirements.txt (ahrefs#388) Fix path to docs (ahrefs#387) Add a readthedocs config file since they now require it. (ahrefs#386) Release 2.15.0 [atddiff] Offer '--no-locations' option (ahrefs#382) Fix 'atddiff --version' (ahrefs#381)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: * atddiff: Breaking changes in the JSON output format of atddiff (ahrefs/atd#382) * atddiff: Fix `atddiff --version` output (ahrefs/atd#379) * atddiff: New experimental option `--no-locations` aimed at producing more stable results that allow diffing successive atddiff reports to spot new findings and ignore old ones (ahrefs/atd#377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-locations
is aimed at producing more stable results that allow diffing successive atddiff reports to spot new findings and ignore old ones.I marked this feature as experimental because it doesn't feel quite right to me. We'll be using it for identifying new findings by comparing the previous atddiff report with the current one in CI. Experience will tell us if it's good enough or if we need something different.
The JSON output format changed. Two records -
full_finding
andfinding
were merged into one,finding
. Here's the atddiff output obtained via git:I think it will be much easier to decipher once we show the snippets of code affected by the findings (feature request #380).
Closes #377
PR checklist
CHANGES.md
is up-to-date