Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable avoidEscape ESLint quotes rule option and remove unused disable directives #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"import/no-cycle": "error",
"no-unused-vars": "off",
"linebreak-style": ["error", "unix"],
"quotes": ["error", "single"],
"quotes": ["error", "single", { "avoidEscape": true }],
"semi": ["error", "always"],
"no-console": ["error", { "allow": ["info", "warn", "error"] }],
"unused-imports/no-unused-imports-ts": "error",
Expand Down
2 changes: 0 additions & 2 deletions src/scripts/add-user-to-group.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,11 @@ export default (
.option('user-id', {
type: 'string',
alias: ['user-login', 'user-email', 'user'],
// eslint-disable-next-line quotes
describe: "The user's ID, login, or email address",
demandOption: true,
})
.option('group', {
type: 'string',
// eslint-disable-next-line quotes
describe: "The group's ID",
demandOption: true,
});
Expand Down
3 changes: 0 additions & 3 deletions src/scripts/create-user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,18 @@ export default (
.option('email', {
type: 'string',
alias: ['login'],
// eslint-disable-next-line quotes
describe: "The new user's login/email",
demandOption: true,
})
.option('fname', {
type: 'string',
alias: ['first-name'],
// eslint-disable-next-line quotes
describe: "The new user's first name",
demandOption: true,
})
.option('lname', {
type: 'string',
alias: ['last-name'],
// eslint-disable-next-line quotes
describe: "The new user's last name",
demandOption: true,
});
Expand Down
2 changes: 0 additions & 2 deletions src/scripts/list-groups.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,13 @@ type ListGroupsOptions = {
export default (rootCommand: RootCommand): Argv<ListGroupsOptions> =>
rootCommand.command(
'list-groups',
// eslint-disable-next-line quotes
"Provides a list of all groups' IDs, email addresses, display names, and statuses. Allows a specification of a user ID to list only groups that the user is a member of.",
// eslint-disable-next-line functional/no-return-void, @typescript-eslint/prefer-readonly-parameter-types
(yargs) => {
// eslint-disable-next-line functional/no-expression-statement
yargs.positional('user', {
type: 'string',
alias: ['user-id'],
// eslint-disable-next-line quotes
describe: "The user's ID",
});
},
Expand Down
1 change: 0 additions & 1 deletion src/scripts/list-users.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ export default (
.positional('group', {
type: 'string',
alias: ['group-id'],
// eslint-disable-next-line quotes
describe: "The group's ID",
})
.option('all', {
Expand Down
1 change: 0 additions & 1 deletion src/scripts/ping.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export default (
}> =>
rootCommand.command(
'ping',
// eslint-disable-next-line quotes
"Pings the okta server to see if it's running and check user credentials along with organisation url",
// eslint-disable-next-line functional/no-return-void, functional/functional-parameters, @typescript-eslint/no-empty-function
() => {},
Expand Down
2 changes: 0 additions & 2 deletions src/scripts/remove-user-from-group.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,11 @@ export default (
.option('user-id', {
type: 'string',
alias: ['user-login', 'user-email', 'user'],
// eslint-disable-next-line quotes
describe: "The user's ID, login, or email address",
demandOption: true,
})
.option('group', {
type: 'string',
// eslint-disable-next-line quotes
describe: "The group's ID",
demandOption: true,
});
Expand Down
Loading