This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Introduce unit tests and corresponding GH workflow #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
unit-tests
branch
from
December 1, 2023 12:04
1822c00
to
fec49bc
Compare
Stefan-Ethernal
force-pushed
the
unit-tests
branch
from
December 1, 2023 12:10
fec49bc
to
a750ba5
Compare
Closed
Stefan-Ethernal
changed the title
Unit Tests
Introduce unit tests and corresponding GH workflow
Dec 1, 2023
Stefan-Ethernal
force-pushed
the
unit-tests
branch
from
December 1, 2023 12:48
2f495d0
to
3eff1a9
Compare
goran-ethernal
requested review from
arnaubennassar,
begmaroman,
vcastellm and
a team
and removed request for
vcastellm,
arnaubennassar and
begmaroman
December 4, 2023 10:50
Stefan-Ethernal
force-pushed
the
unit-tests
branch
from
December 4, 2023 12:31
92b7a9c
to
ab3b012
Compare
rachit77
approved these changes
Dec 4, 2023
vcastellm
reviewed
Dec 4, 2023
vcastellm
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the specific sonarcloud scan: https://github.com/0xPolygon/polygon-edge/blob/develop/.github/workflows/test.yml#L43-L49
Kudos, SonarCloud Quality Gate passed! |
begmaroman
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests to and GH unit tests execution workflow .