-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typevariate and list-based polynomials are isomorphic #922
Merged
felixwellen
merged 33 commits into
agda:master
from
felixwellen:typevariate_equiv_list-based_poly
Nov 3, 2022
Merged
Typevariate and list-based polynomials are isomorphic #922
felixwellen
merged 33 commits into
agda:master
from
felixwellen:typevariate_equiv_list-based_poly
Nov 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omials # Conflicts: # Cubical/Algebra/CommAlgebra/UnivariatePolyList.agda
#917 merged -> ready for review. |
...once the conflicts are resolved. |
# Conflicts: # Cubical/Algebra/Algebra/Properties.agda # Cubical/Algebra/CommAlgebra/UnivariatePolyList.agda
MatthiasHu
requested changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Two comments about consistent style / reusability.
Cubical/Algebra/Polynomials/TypevariateHIT/EquivUnivariateListPoly.agda
Outdated
Show resolved
Hide resolved
MatthiasHu
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows that there is an isomorphism of algebras between the typevariate polynomials (with index type Unit) defined as a HIT and the list-based polynomials.
Depends on #917