Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agda 2.6.4 #22

Merged
merged 6 commits into from
Dec 10, 2023
Merged

agda 2.6.4 #22

merged 6 commits into from
Dec 10, 2023

Conversation

andreasabel
Copy link
Member

  • From Agda 2.6.3 use Agda.TypeChecking.Error.explainWhyInScope
  • Use showInfoError from EmacsTop rather than duplicating it here
  • v0.2.6.4.0: Build with and embed Agda-2.6.4

@@ -77,21 +83,29 @@ library
, base >=4.7 && <5
, bytestring
, containers
, lsp <1.7
, lsp <2
, lsp-types <2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should keep this at < 1.7.

#if MIN_VERSION_Agda(2,6,4)
GoalAndHave expr bndry -> do
-- TODO: render bndry
#else
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banacorn: Here I do not really know how to render the boundary. It would be good to be able to test the output before releasing some rendering. How would one test this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me see if I can release a new version of agda-mode on the VS Code Marketplace so that you can test this with ease!

Copy link
Member

@banacorn banacorn Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just released agda-mode v.0.4.4!

To test the language server:

  1. Build and install the language server on your machine so that als is in PATH
  2. Enable agdaMode.connection.agdaLanguageServer in the settings
  3. Load an Agda file with C-c C-l
  4. If all goes well, you should see "ALS-2.6.4" on the top right corner of the panel. Screenshot 2023-12-03 at 16 47 26.
    You should also see errors like LSP: no handler for: STextDocumentDidOpen popping up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found the reason why there's this TCP tunneling thing on the server. It allow us to develop the language server right in the REPL without having to recompile and reinstall it.

See https://github.com/agda/agda-language-server#hacking for more.

| isNoName (unqualify x) =
vcat ["where", vcat $ fmap render ds]
render (AnyWhere _range ds) = vcat ["where", vcat $ fmap render ds]
#if MIN_VERSION_Agda(2,6,4)
render (SomeWhere _range _er m a ds) =
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently ignoring erasure annotations but I suppose they should be rendered.

@andreasabel andreasabel mentioned this pull request Nov 30, 2023
2 tasks
Copy link
Member

@banacorn banacorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!

@banacorn
Copy link
Member

banacorn commented Dec 9, 2023

agda-mode v.0.4.6 just released!

To test the language server:

Build and install the language server on your machine so that als is in PATH
Enable agdaMode.connection.agdaLanguageServer in the settings
Load an Agda file with C-c C-l
If all goes well, you should see "ALS-2.6.4" on the top right corner of the panel.

@banacorn banacorn marked this pull request as ready for review December 10, 2023 14:57
@banacorn banacorn merged commit c630eac into master Dec 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants