Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reparent grabbed entity onto wrist object upon grab #5565

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

mrxz
Copy link
Contributor

@mrxz mrxz commented Aug 15, 2024

Description:
Proof-of-concept demonstrating the simplified logic for grabbing when reparenting.
The grabbed element is reparented to the wristObject upon grab, and inversely restored to its original parent upon release.

Unrelated to this change:

2c70bc24596dd644084e66b0010dab5b1ff208ef is the first bad commit
commit 2c70bc24596dd644084e66b0010dab5b1ff208ef
Author: Diego Marcos <[email protected]>
Date:   Thu Jul 25 18:25:35 2024 -0700

    Bump THREE to r167

 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

@mrxz mrxz marked this pull request as draft August 15, 2024 16:25
@mrxz mrxz marked this pull request as ready for review November 14, 2024 11:46
@mrxz
Copy link
Contributor Author

mrxz commented Nov 14, 2024

@dmarcos Rebased and updated this PR so that it no longer stores a temp variable on the grabbed entity. No longer marking as a draft as I think it's worth fixing hand-tracking-grab-controls which is currently broken on master.

@mrxz mrxz changed the title POC: Reparent grabbed entity onto wrist object upon grab Reparent grabbed entity onto wrist object upon grab Nov 14, 2024
@dmarcos
Copy link
Member

dmarcos commented Nov 16, 2024

Thanks!

@dmarcos dmarcos merged commit 4a415ba into aframevr:master Nov 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants