Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Homepage #77

Merged
merged 29 commits into from
May 27, 2020
Merged

Update Homepage #77

merged 29 commits into from
May 27, 2020

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Apr 30, 2020

Adds the 32 fiducials that was tweeted to the homepage, replacing the stati image from paper

Looking for some feedback on changes (theres some black space that is in the video, which looked a little bit weird alignment wise. Currently added a 1em white border around the video, but open to suggestions.

@jclauneuro jclauneuro marked this pull request as ready for review May 13, 2020 20:42
- added a "Validate .fcsv file structure", which has same function as " "
  - explicit indication of how to validate the file structure
- grouped human templates together under sub-heading human in dropdown menu
- removed trailing "_afids.fcsv" to the drop down menu

changes made to be more user-friendly and in anticipation for future non-human templates
@kaitj
Copy link
Collaborator Author

kaitj commented May 14, 2020

Added additional changes as discussed yesterday (see #78). Major changes are:

  • Grouped together human templates
  • Added explicit "Check .fcsv file structure" that has same functionality as " " to validate file
  • Removed trailing "_afids.fcsv" to templates in the dropdown menu

Also some coding changes were made to implement the above, in anticipation of future non-human templates.

@kaitj kaitj requested a review from tkkuehn May 14, 2020 18:44
This was referenced May 14, 2020
@kaitj kaitj self-assigned this May 14, 2020
Strip old flexx visualization from project
@tkkuehn
Copy link
Collaborator

tkkuehn commented May 27, 2020

Needs a merge from master

Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good but a couple of nitpicks and one error.

templates/login.html Outdated Show resolved Hide resolved
templates/validator.html Outdated Show resolved Hide resolved
controller.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tkkuehn tkkuehn merged commit c29a45f into master May 27, 2020
@tkkuehn tkkuehn deleted the update-index branch May 27, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants