Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge to fix upload download artifact v4 #642

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Oct 10, 2024

This is the last piece of #631
Did a bunch of name shortening too, so board names are readable.

@tyeth tyeth requested a review from brentru October 10, 2024 17:05
@tyeth
Copy link
Contributor Author

tyeth commented Oct 10, 2024

@brentru This one can be reviewed and then merged into #631 at which point that should be good to go / merge too.

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tooling work, the emojis and shorter names are more readable in CI.

@brentru
Copy link
Member

brentru commented Oct 10, 2024

@tyeth I'm not sure if you want this merged into main or #631, so I'm marking this as approved and leaving the merging up to you.

@tyeth tyeth merged commit d01e5d7 into fix-upload-download-artifact Oct 10, 2024
35 checks passed
@tyeth tyeth deleted the add-merge-to-fix-upload-download-artifact-v4 branch October 11, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants