simplifying CI: ubuntu install #750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Oct 6, 2024
Co-authored-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Yagiz Nizipli <[email protected]>
anonrig
reviewed
Nov 18, 2024
| @@ -38,8 +34,10 @@ jobs: | |||
| - name: Install | |||
| run: cmake --install build | |||
| - name: Prepare test package | |||
| run: cmake -DCMAKE_INSTALL_PREFIX:PATH=../../destination -S tests/installation -B buildbabyada | |||
| run: cmake -DCMAKE_INSTALL_PREFIX:PATH=../../destination -S tests/installation | | |||
There was a problem hiding this comment.
We need to either pass CC=gcc-12 CXX=g++-12 or do sudo ln -sf /usr/bin/gcc-12 /usr/bin/gcc kind of symlink to fix the issue. Ubuntu 22 doesn't include gcc 12 or something newer
There was a problem hiding this comment.
Let us upgrade to ubuntu 24.
Messing around with paths is fragile.
|
@lemire I wonder if installing gtest directly to alpine linux would solve our problem? It seems it's available: https://pkgs.alpinelinux.org/package/edge/main/x86/gtest |
|
@anonrig I do not understand the problem. I have a local alpine image and it works without a problem in it. |
|
Here we go: |
|
So we have a choice:
|
|
Please see #782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub complains that the workflow file is invalid. Let us simplify it.