Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate fuzzers into different files #655

Merged
merged 3 commits into from
May 14, 2024

Conversation

CarlosEduR
Copy link
Member

No description provided.

@anonrig
Copy link
Member

anonrig commented May 13, 2024

Can you also update build.sh file?

@CarlosEduR
Copy link
Member Author

Can you also update build.sh file?

Sure, I have to run linter as well

@anonrig anonrig requested review from jasnell and lemire May 14, 2024 00:50
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@anonrig anonrig marked this pull request as ready for review May 14, 2024 00:50
@CarlosEduR
Copy link
Member Author

@anonrig we should be able to see the results here, right? https://storage.googleapis.com/oss-fuzz-introspector/ada-url/inspector-report/20240513/fuzz_report.html

Just wanted to confirm it is configured correctly.

@anonrig
Copy link
Member

anonrig commented May 14, 2024

@anonrig we should be able to see the results here, right? https://storage.googleapis.com/oss-fuzz-introspector/ada-url/inspector-report/20240513/fuzz_report.html

@CarlosEduR Yes but they run it on a cronjob. The GitHub workflow is merely for local development and does not cover the whole fuzzer.

Basically, oss-fuzz runs a docker file (implemented in https://github.com/google/oss-fuzz/tree/master/projects/ada-url) which executes build.sh in this repository.

@anonrig
Copy link
Member

anonrig commented May 14, 2024

@CarlosEduR Can you also disable memory sanitizer in a different pull-request if you don't mind?

@CarlosEduR
Copy link
Member Author

@CarlosEduR Can you also disable memory sanitizer in a different pull-request if you don't mind?

sure, @CarlosEduR! From the cifuzz.yml, right?

@anonrig anonrig merged commit 2cea09f into ada-url:main May 14, 2024
69 of 70 checks passed
@CarlosEduR
Copy link
Member Author

@anonrig
image

@anonrig
Copy link
Member

anonrig commented May 14, 2024

@CarlosEduR they are not blocked. they just test a specific portion of the codebase ~0.1%. but this is good progress!

@CarlosEduR
Copy link
Member Author

@CarlosEduR they are not blocked. they just test a specific portion of the codebase ~0.1%. but this is good progress!

thanks for explaining that @anonrig, good to know and glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants