-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add git to aarch64 container in CI #652
Conversation
Hmmm... It is failing due to a timeout. So maybe we should leave it as it is. It is currently not running the tests, but, at least, it is testing that we can build the software. |
Nice we merged the workflow, now I intend to take a better look about why it's not running the tests correctly. |
979e88f
to
ae1257c
Compare
I think we actually have a problem that causes Gtest child process to get killed. |
:-/ |
I think we can land this as it is, since it is fixing the timeout issue. |
@anonrig Do you know why it is failing? |
Yeah. We have a problem building with the sanitizers. It does not seem to work, or it produces a binary that cannot run. |
There is definitively something wrong. I tried to simplify the build, but it is still broken. I don't think it is us. |
I think the issue is the sanitizer |
Yes. Once I removed it, then the tests passed. |
Let me try something else. |
I have reenabled sanitizers but with a different distro. We are currently using Ubuntu Noble which is maybe too recent. |
hmmmm... we get a different error. |
@anonrig Have a look!!!!!!!!!!!!!!!!!! |
nice work @lemire! |
The trick is to run with bound checks. It should catch most memory problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing news!
We need git for the tests to run.