Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add git to aarch64 container in CI #652

Merged
merged 10 commits into from
May 14, 2024
Merged

fix: add git to aarch64 container in CI #652

merged 10 commits into from
May 14, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented May 10, 2024

We need git for the tests to run.

@lemire lemire requested a review from anonrig May 10, 2024 16:27
@lemire
Copy link
Member Author

lemire commented May 10, 2024

Hmmm... It is failing due to a timeout.

So maybe we should leave it as it is. It is currently not running the tests, but, at least, it is testing that we can build the software.

@CarlosEduR
Copy link
Member

Nice we merged the workflow, now I intend to take a better look about why it's not running the tests correctly.

@anonrig anonrig force-pushed the adding_git branch 3 times, most recently from 979e88f to ae1257c Compare May 10, 2024 23:55
@anonrig
Copy link
Member

anonrig commented May 11, 2024

I think we actually have a problem that causes Gtest child process to get killed.

@lemire
Copy link
Member Author

lemire commented May 11, 2024

:-/

@anonrig
Copy link
Member

anonrig commented May 11, 2024

I think we can land this as it is, since it is fixing the timeout issue.

@lemire
Copy link
Member Author

lemire commented May 11, 2024

@anonrig Do you know why it is failing?

@lemire
Copy link
Member Author

lemire commented May 11, 2024

Yeah. We have a problem building with the sanitizers. It does not seem to work, or it produces a binary that cannot run.

@lemire
Copy link
Member Author

lemire commented May 11, 2024

There is definitively something wrong. I tried to simplify the build, but it is still broken.

I don't think it is us.

@anonrig
Copy link
Member

anonrig commented May 12, 2024

I think the issue is the sanitizer

@lemire
Copy link
Member Author

lemire commented May 12, 2024

I think the issue is the sanitizer

Yes. Once I removed it, then the tests passed.

@lemire
Copy link
Member Author

lemire commented May 12, 2024

Let me try something else.

@lemire
Copy link
Member Author

lemire commented May 12, 2024

I have reenabled sanitizers but with a different distro. We are currently using Ubuntu Noble which is maybe too recent.

@lemire
Copy link
Member Author

lemire commented May 12, 2024

hmmmm... we get a different error.

tests/CMakeLists.txt Outdated Show resolved Hide resolved
@lemire
Copy link
Member Author

lemire commented May 14, 2024

@anonrig Have a look!!!!!!!!!!!!!!!!!!

@CarlosEduR
Copy link
Member

nice work @lemire!

@lemire
Copy link
Member Author

lemire commented May 14, 2024

The trick is to run with bound checks. It should catch most memory problems.

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing news!

@anonrig anonrig merged commit 77dc0d0 into main May 14, 2024
35 checks passed
@anonrig anonrig deleted the adding_git branch May 14, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants